Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/tree focus box has artifacts on some linux boxes #299

Closed
erco77 opened this issue Nov 27, 2021 · 2 comments
Closed

test/tree focus box has artifacts on some linux boxes #299

erco77 opened this issue Nov 27, 2021 · 2 comments
Assignees

Comments

@erco77
Copy link
Contributor

erco77 commented Nov 27, 2021

Hmm, I know we "solved" the focus box issue in 1.4.x with some kind of changes, but Fl_Tree was not affected, because it's showing those old noisy focus box drawing artifacts again.

It should be noted that Fl_Tree's focus box drawing is handled by the items, Fl_Tree_Item, which has to have its own focus drawing code because it is necessarily does /not/ derive from Fl_Widget, and therefore cannot access Fl_Widget::draw_focus().

Looks like there was a regression in 7a580fd with changes made to Fl_Tree_Item::draw_item_focus() where the workaround for this problem was commented out, causing the issue to reappear.

@erco77 erco77 self-assigned this Nov 27, 2021
@erco77
Copy link
Contributor Author

erco77 commented Nov 27, 2021

tree-focus-artifacts

erco77 added a commit that referenced this issue Nov 27, 2021
Nabbed the current code from Fl_Widget::draw_focus() which solves.
@erco77
Copy link
Contributor Author

erco77 commented Nov 27, 2021

Fixed result, closing.
tree-focus-artifacts-fix

@erco77 erco77 closed this as completed Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant