Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize/redraw broken on macOS 12 #508

Closed
geuzaine opened this issue Oct 1, 2022 · 11 comments
Closed

Resize/redraw broken on macOS 12 #508

geuzaine opened this issue Oct 1, 2022 · 11 comments
Assignees
Labels
fixed The issue or PR was fixed. Platform: macOS platform specific (macOS)

Comments

@geuzaine
Copy link

geuzaine commented Oct 1, 2022

@ManoloFLTK: I have just tested the latest FLTK master (4196daa) with Gmsh on macOS 12 (Monterey), and it breaks window resizing/redrawing. For example, when clicking on some widgets nothing happens until I move the mouse and wait for about 1 second.

Going back to 59fc60e ("Simpler code to support FLTK widgets in macOS OpenGL 3 windows") restores correct behavior. I haven't had time to bisect more.

@ManoloFLTK
Copy link
Contributor

I'm afraid a test app showing the problem would be needed.

@geuzaine
Copy link
Author

geuzaine commented Oct 1, 2022

Ok I'll post something here if I succeed to reproduce the issue with a simple test app.

Meanwhile if you want to see the issue in the real app it's quite easy: on your mac run

git clone https://gitlab.onelab.info/gmsh/gmsh.git
cd gmsh && mkdir build && cd build && cmake -DENABLE_OS_SPECIFIC_INSTALL=1 .. && make -j 8 package

You can then open gmsh-git-MacOSX.dmg and run the app: resize the window and/or open Tools->Options and click on random widgets to see the issue.

@ManoloFLTK
Copy link
Contributor

I tried to build gmsh following your instructions (adding "-DCMAKE_BUILD_TYPE=Debug -DCMAKE_OSX_ARCHITECTURES=arm64" to the cmake command) but obtain an executable called gmsh that runs no GUI, a nearly empty tar.gz file, and no .dmg file :
image

Where does the gmsh build procedure get the FLTK library ?

@ManoloFLTK
Copy link
Contributor

I got gmsh built here now after some more fiddling.

@ManoloFLTK
Copy link
Contributor

No problem here with window resize !
I'm running macOS 13 Ventura, though.

@ManoloFLTK
Copy link
Contributor

Unfortunately, I no longer have access to a running macOS 12.

I have built FLTK and gmsh with SDK 11.3 and deployment target=11.0
and did this with git commits abc6709 (still more recent than 4196daa you mentionned) and 59fc60e. I see no problem resizing wndows and no effect of the changes in the FLTK source code.

Is it possible the errors you've seen result from a mix of distinct commits between the libfltk.a used at gmsh link step and FL/*.h include files used at gmsh compile step ?

@geuzaine
Copy link
Author

geuzaine commented Oct 2, 2022

I just tested by doing a clean FLTK install but I see the same issue. Here's a short video: can you try the same kind of actions (resize by dragging the middle separator, click on the bottom bar) with your Gmsh build?

bug.mov

Basically it seems that the app is missing some redraws, which can be triggered by moving the mouse and waiting for about 1 second.

@ManoloFLTK
Copy link
Contributor

No error here (under macOS 13 public beta) when dragging the middle separator or clicking on the bottom bar with the last FLTK commit.

At this point, it would be very helpful if you could identify the commit where your problems appeared.

@ManoloFLTK
Copy link
Contributor

I see the problem now here too under macOS 11. I should be able to begin an investigation.

ManoloFLTK added a commit that referenced this issue Oct 3, 2022
The problem is visible with test/tile when moving the sub window's border.
This also fixes issue #508
@ManoloFLTK ManoloFLTK self-assigned this Oct 3, 2022
@ManoloFLTK
Copy link
Contributor

This issue should be fixed with the last commit (30efed7).
@geuzaine : please close the issue if you confirm.

@ManoloFLTK ManoloFLTK added active Somebody is working on it Platform: macOS platform specific (macOS) waiting for confirmation waiting for someone's confirmation labels Oct 3, 2022
@geuzaine
Copy link
Author

geuzaine commented Oct 3, 2022

@ManoloFLTK: perfect, that fixes it. Thanks!

@geuzaine geuzaine closed this as completed Oct 3, 2022
@ManoloFLTK ManoloFLTK added fixed The issue or PR was fixed. and removed waiting for confirmation waiting for someone's confirmation active Somebody is working on it labels Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed The issue or PR was fixed. Platform: macOS platform specific (macOS)
Projects
None yet
Development

No branches or pull requests

2 participants