Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failure to call pclose #240

Merged
merged 1 commit into from Jun 26, 2021
Merged

failure to call pclose #240

merged 1 commit into from Jun 26, 2021

Conversation

fire-eggs
Copy link
Contributor

pipe is opened with popen() but pclose() is not called.

Source:
Coverity Scan: Windows build (VC++ 2019)
Reported as "Resource Leak"

@Albrecht-S Albrecht-S merged commit 571ff10 into fltk:master Jun 26, 2021
@Albrecht-S Albrecht-S self-assigned this Jun 26, 2021
@Albrecht-S Albrecht-S added bug Something isn't working fixed The issue or PR was fixed. labels Jun 26, 2021
@Albrecht-S
Copy link
Member

Thanks for the report and the fix. Merged.

@fire-eggs Note: I slightly modified the commit message.

@fire-eggs fire-eggs deleted the table_sort branch June 26, 2021 16:10
@Albrecht-S Albrecht-S mentioned this pull request Jul 3, 2021
Open
Albrecht-S pushed a commit that referenced this pull request Dec 2, 2023
Upgrade bundled nanosvg library to latest upstream commit
384b546 
commit 706eb0618249507c1700cef4a518f73e546b1c38 (upstream/master)
Author: Mikko Mononen <memononen@gmail.com>
Date:   Wed Nov 22 22:47:18 2023 +0200

    Merge pull request #249 from wcout/issue_240

    Fix for #240: Bug: "else" missing

+ FLTK specific extensions, see documentation/src/bundled-libs.dox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Albrecht-S Albrecht-S

Labels
bug Something isn't working fixed The issue or PR was fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fire-eggs @Albrecht-S