Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes fullscreen_active not being correctly set #502

Closed
wants to merge 1 commit into from

Conversation

ggarra13
Copy link
Contributor

When fullscreen() or fullscreen_off() were called the FULLSCREEN flag would not get set when the window was shown (the normal behavior), leading to fullscreen_active() always returning 0.

@Albrecht-S
Copy link
Member

@ggarra13 Thanks for the PR, the patch looks good, according to your description but I'm not going to merge it because that's something Manolo knows better.

@ManoloFLTK What do you think, would you please take (assign) this PR and merge it if it's OK? Please set labels accordingly as well. Thanks

@ManoloFLTK
Copy link
Contributor

The lack of setting the FULLSCREEN flag was occurring only for the X11 platform, whereas the flag was correctly set and unset under other platforms. This is now corrected in the git repo (eb0bba4). This PR is not completely appropriate because it's not X11-platform-specific, and no longer useful.

@ManoloFLTK ManoloFLTK closed this Sep 23, 2022
@ManoloFLTK ManoloFLTK self-assigned this Sep 23, 2022
@ggarra13
Copy link
Contributor Author

I verify it is now working properly at least on macOS and Linux.

@ggarra13
Copy link
Contributor Author

ggarra13 commented Oct 11, 2022 via email

@ManoloFLTK
Copy link
Contributor

@ggarra13 The FULLSCREEN flag is set and cleared under macOS inside functions Fl_Cocoa_Window_Driver::fullscreen_on() and Fl_Cocoa_Window_Driver::fullscreen_off()
which call Fl_Widget->_set_fullscreen() and Fl_Widget->_clear_fullscreen().

Therefore, I believe the problem raised here to be resolved.

@ggarra13 ggarra13 deleted the fullscreen_active branch October 14, 2022 16:26
@ggarra13
Copy link
Contributor Author

Correct. I am closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants