Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FL_DEPRECATED macro to mark position() method that shadow Fl_Widget::position() #69 #666

Merged
merged 7 commits into from
Feb 2, 2023

Conversation

MatthiasWM
Copy link
Contributor

No description provided.

@MatthiasWM MatthiasWM changed the title FL_DEPRECATED macro to mark position() method that shadow Fl_Widget::position() #79 FL_DEPRECATED macro to mark position() method that shadow Fl_Widget::position() #69 Jan 31, 2023
@MatthiasWM MatthiasWM marked this pull request as draft January 31, 2023 13:17
@MatthiasWM MatthiasWM marked this pull request as ready for review January 31, 2023 13:23
FL/fl_attr.h Outdated Show resolved Hide resolved
FL/fl_attr.h Outdated Show resolved Hide resolved
@Albrecht-S
Copy link
Member

That's a great work, I like it. The restructured fl_attr.h looks good (but see my comments), and the new FL_DEPRECATED macro is a great achievement.

I wonder how you found out which MSVC version supports which "dialect" of the deprecated attribute. Awesome.

Note that I just read the diffs, I couldn't test anything yet, hence no "official review" so far. But everything I saw looks good.

@MatthiasWM
Copy link
Contributor Author

I wonder how you found out which MSVC version supports which "dialect" of the deprecated attribute. Awesome.

Thanks. Lots and lots of Google and StackOverflow.

@MatthiasWM
Copy link
Contributor Author

PS: in this particular case, the BOOST source code...

@MatthiasWM MatthiasWM merged commit 1aa6c4f into fltk:master Feb 2, 2023
@MatthiasWM MatthiasWM deleted the position branch February 2, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants