Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Add check to verify requirements (widevine and network status) #7

Merged
merged 1 commit into from Jun 12, 2019

Conversation

flubshi
Copy link
Owner

@flubshi flubshi commented May 30, 2019

This adds a new menu entry to addon configuration to check and install for widevine and to check for waipu network access.
This allows self diagnosis for users if waipu is not working.

New menu entry:
image

Check result:
image

@ksooo
Copy link
Collaborator

ksooo commented May 30, 2019

Wouldn't it make more sense to implement this few lines of code in C++ instead of Python? Why that complicated? Or is this script used elsewhere, from outside Kodi?

Just asking...

@flubshi
Copy link
Owner Author

flubshi commented May 30, 2019

I agree, I am also not very happy with this workaround. I would love to see a cleaner solution for setting up widevine, but I currently don't know how to implement.
The module script.module.inputstreamhelper manages widevine setup and is the recommended solution for video plugins. As far as I know. Thus, in my opinion it makes no sense to re-implement widevine setup. The cleanest solution is to utilize inputstreamhelper.
I had several ideas to implement this:

Call inputstreamhelper from pvr plugin via JSONRPC:

  • Problem 1: inputstreamhelper addon is a library and it seems not possible to call library methods directly
  • Problem 2: How to submit a JSONRPC call from a pvr plugin?

Invoke inputstreamhelper library from pvr plugin:

  • Problem: No interface to use python kodi libraries from pvr plugin

That's why I decided to add a simple python helper script that imports inputstreamhelper and checks/installs widevine. Easiest way to integrate this was as RunScript settings menu entry.

But as mentioned, it would be great to have a cleaner solution. Do you have any hints?

@ksooo
Copy link
Collaborator

ksooo commented May 30, 2019

Sorry, I don't have a better idea. Maybe @peak3d has some thoughts on this.

@flubshi
Copy link
Owner Author

flubshi commented Jun 11, 2019

Since there is currently no better solution - I think this workaround is good to go.
@ksooo or are you vetoing?

@ksooo
Copy link
Collaborator

ksooo commented Jun 12, 2019

No veto on my end, but maybe @peak3d has an opinion?

@peak3d
Copy link

peak3d commented Jun 12, 2019

I'm fine with that - I don't see alternatives currently 👍

@flubshi
Copy link
Owner Author

flubshi commented Jun 12, 2019

Thanks for all your feedback! Will merge now :)

@flubshi flubshi merged commit 9c1c540 into Matrix Jun 12, 2019
@flubshi flubshi deleted the matrix_check_requirements branch June 12, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants