Improvement: Select tv channel logo after for-loop #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flubshi
added
Type: Improvement
|
Don't you think it makes more sense to choose more descriptive commit messages containing the functional change instead the (technical) code change?
... says nothing to anybody except you. |
flubshi
force-pushed
the
improve_icon_selection
branch
from
8c6d8d2
to
65691c8
Compare
|
I am still learning. Thanks for your feedback! Is this an acceptable description? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, selection of tv channel logo is within the for-loop to iterate over all existing logos. Thus, it is compared and setted multiple times. With this commit, the tv channel logo is selected and assigned after iterated over all icons.
This was the originally intended implementation.