fix: Canonicalize variable in object creation or copy if variable is a stream #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DieMyst
changed the title
DieMyst
changed the title
folex
reviewed
Jan 23, 2023
Comment on lines
37
to
43
| CallServiceModel( | ||
| LiteralModel("\"json\"", ScalarType.string), | ||
| "obj", | ||
| CallModel( | ||
| args, | ||
| CallModel.Export(result.name, result.`type`) :: Nil | ||
| ) |
There was a problem hiding this comment.
Maybe move that pattern to a function so it's more readable? I see you do service calls like that in a few places.
Something like this might be nice (pseudocode)
def callService(service: String, function: String, args: HList) -> CallServiceModel = {
CallServiceModel(LiteralModel(s"\"$service\"", ScalarType.string), function, args)
}
folex
reviewed
Jan 23, 2023
Comment on lines
128
to
129
| ldfixed <- canonicalizeIfStream(ld._1, ld._2) | ||
| rdfixed <- canonicalizeIfStream(rd._1, rd._2) |
There was a problem hiding this comment.
Suggested change
| ldfixed <- canonicalizeIfStream(ld._1, ld._2) | |
| rdfixed <- canonicalizeIfStream(rd._1, rd._2) | |
| ldCanon <- canonicalizeIfStream(ld._1, ld._2) | |
| rdCanon <- canonicalizeIfStream(rd._1, rd._2) |
folex
reviewed
Jan 23, 2023
Comment on lines
37
to
44
| val copyOp = CallServiceModel( | ||
| LiteralModel("\"json\"", ScalarType.string), | ||
| "puts", | ||
| CallModel( | ||
| value +: args, | ||
| CallModel.Export(result.name, result.`type`) :: Nil | ||
| ) | ||
| ).leaf |
There was a problem hiding this comment.
same, def callService might make this more readable
folex
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes LNG-112