Run aqua code from CLI #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of import, dirty WIP code
alari
reviewed
Oct 7, 2021
alari
reviewed
Oct 7, 2021
alari
reviewed
Oct 7, 2021
npm/aqua/caller.aqua
Outdated
| @@ -0,0 +1,9 @@ | |||
| service Console("console"): | |||
There was a problem hiding this comment.
Why does this file exist in the npm/aqua folder?
| val multiaddrOpt: Opts[String] = | ||
| Opts | ||
| .option[String]("addr", "Relay multiaddress", "a") | ||
| .withDefault("/dns4/stage.fluence.dev/tcp/19002/wss/p2p/12D3KooWMigkP4jkVyufq5JnDJL6nXvyjeaDNpRfEZqQhsG3sYCU") |
There was a problem hiding this comment.
I suppose a Krasnodar network's node should be there.
| @@ -134,7 +138,9 @@ object AquaCli extends IOApp with Logging { | |||
| helpFlag = false, | |||
| None | |||
| )( | |||
| main[IO](runtime), | |||
| { | |||
| @@ -33,6 +36,8 @@ object AppOps { | |||
| Validated.fromEither(toLogLevel(str)) | |||
| } | |||
|
|
|||
| def runCom[F[_]: Monad: Files: AquaIO: Async](implicit ec: ExecutionContext): Opts[F[ExitCode]] = Opts.subcommand(RunOpts.runCommand[F]) | |||
| import scala.concurrent.{ExecutionContext, Future} | ||
|
|
||
| object RunCommand { | ||
| def run[F[_]: Monad: Files: AquaIO: Async](multiaddr: String, func: String, input: Path, imps: List[Path])(implicit ec: ExecutionContext): F[Unit] = ??? |
| ) | ||
| _ <- peer.stop().toFuture | ||
| } yield { | ||
| Validated.Valid({}) |
|
|
||
| val generatedFuncName = "callerUniqueFunction" | ||
|
|
||
| def run[F[_]: Monad: Files: AquaIO: Async]( |
| AirBackend, | ||
| config | ||
| ) | ||
| parsingTime = System.currentTimeMillis() |
There was a problem hiding this comment.
Use Timer typeclass instead.
With System.currentTimeMillis you actually don't know what time you are measuring: when a FlatMap case class is built, or when it's executed, or what.
|
|
||
| object RunCommand extends Logging { | ||
|
|
||
| def funcCall(multiaddr: String, funcName: String, air: Generated, config: TransformConfig)( |
alari
approved these changes
Oct 12, 2021
|
Please update the minor version and add the performance improvements which are already implemented, and let's have it in the wild as an unstable experimental feature. |
DieMyst
added a commit
that referenced
this pull request
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aqua functions could be run from the console:
This feature won't be published until fixing performance issues