Fixes topology for co #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DieMyst
approved these changes
Dec 29, 2021
folex
reviewed
Dec 29, 2021
| @@ -371,7 +372,7 @@ object Topology extends Logging { | |||
| SeqNext | |||
| case (_, _: ForTag) => | |||
| For | |||
| case (_, ParTag | ParTag.Detach) => | |||
| case (_, ParTag) => // No begin optimization for detach | |||
There was a problem hiding this comment.
begin optimization is disabled for detach. The comment I left will help me more. Don't understand your reply.
There was a problem hiding this comment.
I couldn't read it, so I guessed there's a typo. From what you've explained, it seems I guessed correctly.
There was a problem hiding this comment.
begin optimization is disabled for detach
sounds very easy to understand :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes topology for
co, but adds one unnecessarynoopcall. Not sure how to remove it.