-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Math sequence fixes #476
Math sequence fixes #476
Conversation
def brackets(basic: P[ValueToken[Span.S]]): P[ValueToken[Span.S]] = | ||
basic.between(`(`, `)`).backtrack | ||
|
||
val atom: P[ValueToken[S]] = P.oneOf( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is it? Why it's not private?
Nil | ||
) | ||
|
||
// One of entry points for parsing the whole math expression |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment for _value
is the same as for value
, but they're different. Are both used as entry points? Why have two?
And things like foo()
or "hello"
have nothing about math.
No description provided.