Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print help on errors in CLI #507

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Don't print help on errors in CLI #507

merged 3 commits into from
Apr 28, 2022

Conversation

DieMyst
Copy link
Member

@DieMyst DieMyst commented Apr 28, 2022

fixes #493

@DieMyst DieMyst requested a review from alari April 28, 2022 11:39
@@ -1,6 +1,7 @@
package aqua

import aqua.builder.{ArgumentGetter, Service}
import aqua.io.OutputPrinter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it used?

val command = Command("aqua", "Aqua Compiler", false)(main[IO](runtime))
for {
parseResult: Either[Help, IO[ExitCode]] <- Sync[IO].delay(
command.parse(PlatformApp.ambientArgs getOrElse args, sys.env)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a comment what happens there. WTF ambientArgs?

@DieMyst DieMyst merged commit 7c110ff into main Apr 28, 2022
@DieMyst DieMyst deleted the handle-help-in-cli branch April 28, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not print entire help on error in CLI arguments
2 participants