Go-to definitions location between files #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DXJ-32 `Ctrl + click` that works between multiple files
Navigation in aqua code between different aqua files depends on DXJ-21 |
alari
approved these changes
Jun 2, 2022
| type ValidatedCtxT[I, E, S[_]] = ValidatedCtx[I, E, S] => ValidatedCtx[I, E, S] | ||
| type Err = AquaError[I, E, S] | ||
| type Ctx = NonEmptyMap[I, C] | ||
| // TODO: remove CompilerState[S] from the left |
| @@ -22,91 +22,52 @@ import cats.syntax.semigroup.* | |||
| import cats.{~>, Comonad, Monad, Monoid, Order} | |||
| import scribe.Logging | |||
|
|
|||
| trait AquaCompiler[C] extends Logging { | |||
| class AquaCompiler[F[_]: Monad, E, I: Order, S[_]: Comonad, C]( | |||
There was a problem hiding this comment.
Can do C: Monoid : Picker, just for the sake of beauty :)
| def finCtx: RawContext => ValidatedNec[SemanticError[S], RawContext] = | ||
| finInitCtx(_, initCtx) | ||
| } | ||
| class HeaderHandler[S[_]: Comonad, C](implicit |
There was a problem hiding this comment.
Why HeaderHandler?
Can you move it to a separate file
| def addPart(ctx: A, part: (A, RawPart)): A | ||
| } | ||
|
|
||
| final class PickerOps[A: Picker](p: A) { |
There was a problem hiding this comment.
Any way to have top-level classes in their own files?
|
Could you update the minor Aqua version please? I think it's time to make a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add compiler implementation that returns a new context with information about necessary tokens.
fixes DXJ-32