Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: separate withdraw - breaking changes (N02) #419

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

elshan-eth
Copy link
Collaborator

  • breaking changes for CLI
  • to withdraw CC reword, CLI needs to call fixReward before withdrawReward
  • to withdraw CC collateral, CL needs to call withdrawCollateral after finishCommitment

@AlcibiadesCleinias
Copy link
Contributor

also it adds possibility for anyone (prev. only provider) to removeCUfromCC if conditions are met

@elshan-eth
Copy link
Collaborator Author

elshan-eth commented Apr 8, 2024

also it adds possibility for anyone (prev. only provider) to removeCUfromCC if conditions are met

I didn't quite get it. Now any address can call removeCUfromCC. We have no restrictions for this

@shamsartem shamsartem added e2e Run e2e tests clean-cache Runs forge clean labels Apr 16, 2024
@github-actions github-actions bot removed the clean-cache Runs forge clean label Apr 16, 2024
@elshan-eth elshan-eth changed the title fix!: separate withdraw - breaking changes fix!: separate withdraw - breaking changes (N02) Apr 16, 2024
@folex folex force-pushed the main branch 2 times, most recently from 742150d to c661a2e Compare July 24, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants