Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all configuration files from classpath to docker directories #701

Closed
folex opened this issue May 31, 2019 · 1 comment
Closed

Move all configuration files from classpath to docker directories #701

folex opened this issue May 31, 2019 · 1 comment
Assignees
Labels
~infrastructure component: infrastructure ~node component: node ~statemachine component: statemachine ~virtual machine component: virtual machine ~worker component: worker

Comments

@folex
Copy link
Member

folex commented May 31, 2019

Currently, reference.conf configs, and some application.conf also live inside .jar files. This makes it pretty hard to introspect them in case of some misunderstanding in face of bugs or alike.

Moving them to docker's filesystem would make it easier to read actual configs used by our apps.

@folex folex added ~virtual machine component: virtual machine ~infrastructure component: infrastructure ~node component: node ~worker component: worker ~statemachine component: statemachine labels May 31, 2019
@folex folex self-assigned this May 31, 2019
@alari
Copy link
Member

alari commented May 31, 2019

Looks like a duplicate of #464.

reference.conf files are very handy to have in corresponding modules, but we definitely should get rid of bundling application.conf anywhere -- it should be provided as a volume.

On another hand, reference.conf could be of use iff we call ConfigFactory.load() in the appropriate module, or assume that it's going to be called just like we expect it to be on the end of the world. This way, configuration becomes an obscure aspect of the program.

Let's not move conf files to docker directories. Let's aim to remove all config files from the source tree, and provide only application.conf files in docker volumes (one in node, another one in statemachine).

And reading the actual configs sounds like a different story to config files management, don't you think so?

@alari alari closed this as completed Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
~infrastructure component: infrastructure ~node component: node ~statemachine component: statemachine ~virtual machine component: virtual machine ~worker component: worker
Projects
None yet
Development

No branches or pull requests

2 participants