Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wasmtime-backend): host stack size for WASM modules runtime has been increased to manage with AIR fold over 1023 elements in AquaVM #390

Merged
merged 1 commit into from Nov 1, 2023
Merged

feat(wasmtime-backend): host stack size for WASM modules runtime has been increased to manage with AIR fold over 1023 elements in AquaVM #390

merged 1 commit into from Nov 1, 2023

Conversation

raftedproc
Copy link
Contributor

There is stack overflow happens for AquaVM benchmarking tests uses 1023 elements in a stream.

@raftedproc raftedproc added P-high priority: high A-core-runtime area: core runtime components labels Nov 1, 2023
@raftedproc raftedproc self-assigned this Nov 1, 2023
@ValeryAntopol ValeryAntopol changed the title feat(core-runtime): host stack size for WASM modules runtime has beenincreased to manage with AIR fold over 1023 elements in AquaVM feat(wasmtime-bakcend): host stack size for WASM modules runtime has been increased to manage with AIR fold over 1023 elements in AquaVM Nov 1, 2023
ValeryAntopol
ValeryAntopol approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@ValeryAntopol ValeryAntopol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fluencebot fluencebot added the e2e Run e2e workflow label Nov 1, 2023
@raftedproc
feat(core-runtime): host stack size for WASM modules runtime has been…
e448e11 
… increased to manage with AIR `fold` over 1023 elements in AquaVM
@ValeryAntopol ValeryAntopol changed the title feat(wasmtime-bakcend): host stack size for WASM modules runtime has been increased to manage with AIR fold over 1023 elements in AquaVM feat(wasmtime-backend): host stack size for WASM modules runtime has been increased to manage with AIR fold over 1023 elements in AquaVM Nov 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

Pull Request Test Coverage Report for Build 6718881369

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 0.418%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/wasmtime-backend/src/lib.rs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
crates/wasmtime-backend/src/lib.rs 1 0.0%
Totals Coverage Status
Change from base Build 6616846004: 0.0%
Covered Lines: 31
Relevant Lines: 7422
💛 - Coveralls

@raftedproc raftedproc merged commit 0f5d08a into master Nov 1, 2023
25 of 26 checks passed
@raftedproc raftedproc deleted the feat/host-stack-size branch November 1, 2023 11:39
@fluencebot fluencebot mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValeryAntopol ValeryAntopol ValeryAntopol approved these changes

Assignees

@raftedproc raftedproc

Labels
A-core-runtime area: core runtime components e2e Run e2e workflow P-high priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raftedproc @ValeryAntopol @fluencebot