Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tracing): introduce deal_id-based trace logs to particle execution #1656

Merged
merged 11 commits into from
Jul 6, 2023
Merged

feat(tracing): introduce deal_id-based trace logs to particle execution #1656

merged 11 commits into from
Jul 6, 2023

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Jun 28, 2023 •
edited
Loading

Description

Adds a span propagation with the additional deal_id tracing information.

Motivation

Simplify the passing of the contextual information for debugging (i.e deal_id)

Related Issue(s)

https://linear.app/fluence/issue/NET-493/small-span-demo

Proposed Changes

Checklist

  • The code follows the project's coding conventions and style guidelines (https://doc.rust-lang.org/1.0.0/style/README.html).
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Screenshots (if applicable)

Additional Notes

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@linear
Copy link

linear bot commented Jun 28, 2023

NET-493 Small Span Demo

@gurinderu gurinderu changed the title feat: Deal_id tracing feat(tracing): Deal_id tracing Jun 28, 2023
@gurinderu gurinderu added the e2e Run e2e workflow label Jun 29, 2023
@gurinderu gurinderu marked this pull request as ready for review June 29, 2023 11:51
@gurinderu gurinderu requested review from folex, justprosh and kmd-fl and removed request for folex July 4, 2023 10:43
folex
folex reviewed Jul 4, 2023
View reviewed changes
aquamarine/src/actor.rs Outdated Show resolved Hide resolved
folex
folex reviewed Jul 4, 2023
View reviewed changes
aquamarine/src/actor.rs Outdated Show resolved Hide resolved
folex
folex reviewed Jul 4, 2023
View reviewed changes
aquamarine/src/actor.rs Outdated Show resolved Hide resolved
folex
folex reviewed Jul 4, 2023
View reviewed changes
aquamarine/src/log.rs Outdated Show resolved Hide resolved
@gurinderu gurinderu requested a review from folex July 5, 2023 14:22
@gurinderu gurinderu changed the title feat(tracing): Deal_id tracing feat(tracing): introduce deal_id-based trace logs to particle execution Jul 5, 2023
@gurinderu gurinderu enabled auto-merge (squash) July 5, 2023 18:37
kmd-fl
kmd-fl reviewed Jul 6, 2023
View reviewed changes
Copy link
Contributor

@kmd-fl kmd-fl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like how it looks. :c
Sad there's no other nicer way to do the tracing

@gurinderu gurinderu merged commit 760e7c8 into master Jul 6, 2023
15 checks passed
@gurinderu gurinderu deleted the feature/net-493 branch July 6, 2023 13:32
@fluencebot fluencebot mentioned this pull request Jul 6, 2023
Merged
This was referenced Jul 20, 2023
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmd-fl kmd-fl kmd-fl left review comments

@folex folex folex approved these changes

@justprosh justprosh justprosh approved these changes

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gurinderu @folex @justprosh @kmd-fl