Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(env, log)!: RUST_LOG and other envs parsing #1755

Merged
merged 8 commits into from
Aug 14, 2023
Merged

fix(env, log)!: RUST_LOG and other envs parsing #1755

merged 8 commits into from
Aug 14, 2023

Conversation

folex
Copy link
Member

@folex folex commented Aug 12, 2023

Description

  • Fix parsing certain config fields of Array type from ENV variables.
  • Fix RUST_LOG parsing: trim whitespaces
  • Load RUST_LOG only once, I believe it was twice before (in main.rs and layers.rs). @gurinderu, wdyt?
  • ⚠️ Crash if RUST_LOG is incorrect. @nahsi, wdyt?

Motivation

A lot of lists in config did not parse from ENV before. Tabs after newlines in RUST_LOG didn't parse.

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@folex folex changed the title fix(env): fix env parsing fix(env, log): trim whitespaces in RUST_LOG Aug 12, 2023
@folex folex changed the title fix(env, log): trim whitespaces in RUST_LOG fix(env, log): trim whitespaces in RUST_LOG, parse lists from ENV Aug 12, 2023
@folex folex changed the title fix(env, log): trim whitespaces in RUST_LOG, parse lists from ENV fix(env, log): RUST_LOG and other envs parsing Aug 12, 2023
@folex folex changed the title fix(env, log): RUST_LOG and other envs parsing fix(env, log)!: RUST_LOG and other envs parsing Aug 12, 2023
@folex folex requested review from nahsi and removed request for justprosh and kmd-fl August 12, 2023 02:07
@folex folex added the e2e Run e2e workflow label Aug 14, 2023
@folex folex enabled auto-merge (squash) August 14, 2023 15:23
@folex folex merged commit ea172c1 into master Aug 14, 2023
22 checks passed
@folex folex deleted the decider_tests branch August 14, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants