Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use particle signature as id for actors [NET-540] #1877

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

justprosh
Copy link
Member

@justprosh justprosh commented Oct 31, 2023

Description

Use particle signature instead of particle id in actors and particle data store.
UPD: use particle signature for data store will be implemented with the one of the next avm updates, because former particle id is used as salt for avm signatures

Motivation

Anyone can set any particle id, so it is safer to use a unique particle signature for such purposes.

Proposed Changes

  • use particle signature in actors hashmap
  • use particle signature in hex for particle data store
  • leave all other logs and traces with legacy particle id for now for easy debugging

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

aquamarine/src/plumber.rs Outdated Show resolved Hide resolved
@justprosh justprosh added the e2e Run e2e workflow label Nov 1, 2023
@justprosh justprosh changed the title feat: use particle signature as id for actors feat: use particle signature as id for actors [NET-540] Nov 1, 2023
Copy link

linear bot commented Nov 1, 2023

@justprosh justprosh marked this pull request as ready for review November 1, 2023 12:42
aquamarine/src/plumber.rs Outdated Show resolved Hide resolved
@justprosh justprosh requested a review from folex November 1, 2023 13:03
@justprosh justprosh merged commit da84a39 into master Nov 7, 2023
16 checks passed
@justprosh justprosh deleted the signature_id branch November 7, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants