-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cleanup): cleanup par + max batch size #1967
Conversation
250efe0
to
ce563f1
Compare
@@ -106,24 +107,29 @@ impl ParticleDataStore { | |||
} | |||
|
|||
pub async fn batch_cleanup_data(&self, data: Vec<(String, PeerId)>) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is data: Vec<(String, PeerId)>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pairs of the particle id and worker id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's rename data
argument to something sensible, otherwise it doesn't make any sense. Reads like you're going to clean up Vec<(String, PeerId)>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Description
In this PR we fix the count of cleanup batch and parallelize deletion.
Motivation
If cleanup is slow it dramatically decreases the whole system performance.
Proposed Changes
Additional Notes
Checklist
Reviewer Checklist