fix(particle-vault): refactor particle vault usage #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmd-fl
changed the title
kmd-fl
changed the title
folex
reviewed
Feb 20, 2024
folex
reviewed
Feb 20, 2024
folex
reviewed
Feb 20, 2024
folex
reviewed
Feb 20, 2024
folex
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor particle vault usage
Motivation
Initially this PR was about introducing the signature into the particle vault name, but it came up to be a harder task, so now this PR is all about refactoring
Proposed Changes
ParticleParamsin someParticleVaultAPI methodsModuleRepositorythat used its own way to create a vault name. I moved some unrelated code outside of the structure and usedParticleVaultto work with the vault.