Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aquavm)!: aquavm mem limits from config [fixes VM-425] #2111

Merged
merged 26 commits into from
Mar 5, 2024

Conversation

raftedproc
Copy link
Contributor

@raftedproc raftedproc commented Feb 23, 2024

Description

This patch reads optional arguments size limits from Nox config and hands the values over to AquaVM.

Motivation

AquaVM better read its arguments limits from Nox configuration better than update hardcoded limits in AquaVM.

Related Issue(s)

VM-425

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@raftedproc raftedproc self-assigned this Feb 23, 2024
Copy link

linear bot commented Feb 23, 2024

@gurinderu gurinderu changed the title Feat/vm 425 aquavm mem limits from config 2 feat(avm): aquavm mem limits from config Feb 23, 2024
@gurinderu gurinderu changed the title feat(avm): aquavm mem limits from config feat(avm)!: aquavm mem limits from config Feb 23, 2024
@gurinderu gurinderu changed the title feat(avm)!: aquavm mem limits from config feat(aquavm)!: aquavm mem limits from config [fixes VM-425] Feb 23, 2024
@raftedproc raftedproc added the e2e Run e2e workflow label Feb 23, 2024
@gurinderu gurinderu force-pushed the feat/vm-425-aquavm-mem-limits-from-config-2 branch 2 times, most recently from 419b2bc to 5d24bb2 Compare March 1, 2024 11:02
@gurinderu gurinderu merged commit a732f5c into master Mar 5, 2024
17 checks passed
@gurinderu gurinderu deleted the feat/vm-425-aquavm-mem-limits-from-config-2 branch March 5, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants