-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): add metrics in chain-listener [NET-806] #2208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall very cool! Thx very much for explanatory comments 🙏🙏🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
// how many proofs transaction are failed | ||
ccp_proofs_tx_failed: CounterWithExemplar<TxLabel>, | ||
// How many blocks we have received from the newHead subscription | ||
blocks_seen: CounterWithExemplar<BlockLabel>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this be a gauge with a block number?
// How many blocks we have received from the newHead subscription | ||
blocks_seen: CounterWithExemplar<BlockLabel>, | ||
// How many block we manage to process while processing the block | ||
blocks_processed: Counter, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this, too
Description
Add some metrics to the ChainListener module.
Proposed Changes
Add a pack of metrics:
Additional Notes
We were discussing some refactoring, and I did the tiniest amount of refactoring, but I think we should do it in a separate PR.