fix(connection-pool): Keep only fluence peers in the connection pool #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurinderu
force-pushed
the
feature/net-358
branch
from
58a5468
to
640f13f
Compare
nahsi
changed the title
folex
reviewed
Feb 2, 2023
folex
reviewed
Feb 2, 2023
folex
reviewed
Feb 2, 2023
crates/kademlia/src/behaviour.rs
Outdated
| @@ -160,7 +160,7 @@ impl Kademlia { | |||
| } | |||
| } | |||
|
|
|||
| pub fn add_kad_node(&mut self, peer: PeerId, addresses: Vec<Multiaddr>) { | |||
| pub fn add_kad_node(&mut self, peer: PeerId, addresses: &Vec<Multiaddr>) { | |||
folex
reviewed
Feb 2, 2023
folex
approved these changes
Feb 2, 2023
justprosh
approved these changes
Feb 2, 2023
folex
reviewed
Feb 3, 2023
folex
reviewed
Feb 3, 2023
connection-pool/src/behaviour.rs
Outdated
| @@ -250,12 +251,12 @@ impl ConnectionPoolBehaviour { | |||
| self.subscribers.push(outlet); | |||
| } | |||
|
|
|||
| pub fn add_discovered_addresses(&mut self, peer_id: PeerId, addresses: Vec<Multiaddr>) { | |||
| pub fn add_discovered_addresses(&mut self, peer_id: PeerId, addresses: &[Multiaddr]) { | |||
There was a problem hiding this comment.
You clone unconditionally, maybe no need to accept &[Multiaddr] and accept Vec instead? So that the calling side is responsible for cloning and it's more transparent
folex
reviewed
Feb 3, 2023
crates/kademlia/src/behaviour.rs
Outdated
| @@ -160,7 +160,7 @@ impl Kademlia { | |||
| } | |||
| } | |||
|
|
|||
| pub fn add_kad_node(&mut self, peer: PeerId, addresses: Vec<Multiaddr>) { | |||
| pub fn add_kad_node(&mut self, peer: PeerId, addresses: &[Multiaddr]) { | |||
There was a problem hiding this comment.
Same. Maybe pass Vec if we clone it anyway?
folex
reviewed
Feb 3, 2023
| } | ||
| } else { | ||
| log::debug!( | ||
| target: "protocols", |
There was a problem hiding this comment.
lets change to target: network or target: blocked. protocols is too narrow, don't think we'll have much of these so no sense in grouping them.
folex
reviewed
Feb 3, 2023
| @@ -61,18 +90,18 @@ impl FluenceNetworkBehaviour { | |||
| } | |||
| } | |||
|
|
|||
| fn filter_addresses(addresses: Vec<Multiaddr>, allow_local: bool) -> Vec<Multiaddr> { | |||
| fn filter_addresses(addresses: &[Multiaddr], allow_local: bool) -> Vec<Multiaddr> { | |||
There was a problem hiding this comment.
Here you also clone in all cases, so makes sense to pass Vec
folex
reviewed
Feb 3, 2023
| @@ -160,7 +160,7 @@ impl Kademlia { | |||
| } | |||
| } | |||
|
|
|||
| pub fn add_kad_node(&mut self, peer: PeerId, addresses: &[Multiaddr]) { | |||
| pub fn add_kad_node(&mut self, peer: PeerId, addresses: Vec<Multiaddr>) { | |||
| for addr in addresses { | |||
| self.kademlia.add_address(&peer, addr.clone()); | |||
There was a problem hiding this comment.
You should be able to remove .clone
folex
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.