feat(builtins)!: add worker.list, move spell.list to worker scope [fixes NET-401 NET-435] #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justprosh
changed the title
folex
reviewed
Mar 28, 2023
folex
reviewed
Mar 28, 2023
| @@ -80,7 +80,12 @@ impl Sorcerer { | |||
| } | |||
|
|
|||
| async fn resubscribe_spells(&self) { | |||
| for (spell_id, _) in self.spell_storage.get_registered_spells() { | |||
| for spell_id in self | |||
There was a problem hiding this comment.
is it possible that a single spell exists on several workers?
There was a problem hiding this comment.
if not, please add a comment on why. It's not clear how you guarantee that.
There was a problem hiding this comment.
it is guaranteed by service structure, it has only one field worker_id and it is the only source of truth about worker_id
There was a problem hiding this comment.
I don't know where to put this comment
kmd-fl
approved these changes
Mar 29, 2023
folex
changed the title
folex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.