Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: collect separate metrics for root alised services and worker spells [fixes NET-431] #1539

Merged
merged 7 commits into from
Apr 6, 2023
Merged

fix: collect separate metrics for root alised services and worker spells [fixes NET-431] #1539

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7de8555
collect separate metrics for root alised services and worker spells
kmd-fl Mar 29, 2023
a5bb31b
Merge branch 'master' into restrict-metrics-collection
kmd-fl Mar 29, 2023
2c4984e
Merge branch 'master' into restrict-metrics-collection
kmd-fl Mar 31, 2023
048a4cc
fix lint
kmd-fl Mar 31, 2023
b29bdc0
check only first alias
kmd-fl Apr 4, 2023
0318b03
Merge branch 'master' into restrict-metrics-collection
kmd-fl Apr 4, 2023
8acba22
Merge branch 'master' into restrict-metrics-collection
kmd-fl Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion particle-services/src/app_services.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,20 @@ impl ParticleAppServices {
// ));
// }

let service_type = ServiceType::Service(service.aliases.first().cloned());
// Metrics collection are enables for services with aliases which are installed on root worker or worker spells.
let allowed_alias = if worker_id == self.config.local_peer_id {
service.aliases.first().cloned()
} else if service
.aliases
.first()
.map(|alias| alias == "worker-spell")
.unwrap_or(false)
{
Some("worker-spell".to_string())
} else {
None
};
let service_type = ServiceType::Service(allowed_alias);

// TODO: move particle vault creation to aquamarine::particle_functions
self.create_vault(&particle.id)?;
Expand Down