feat: add service metrics for spells [fixes NET-441] #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmd-fl
force-pushed
the
service-metrics-for-spells
branch
from
cc072f3
to
198ef91
Compare
folex
reviewed
Apr 11, 2023
| @@ -324,17 +328,13 @@ impl ParticleAppServices { | |||
| )?; | |||
|
|
|||
| // tmp hack to forbid spell removal via srv.remove | |||
There was a problem hiding this comment.
is it temporary? What's the plan to fix it? @justprosh
There was a problem hiding this comment.
I think it is fixed with service.is_spell by @kmd-fl
folex
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new service type for spells and spells with aliases.
Extend some new metrics with labels:
And add a hack to detect that a service is a spell fast, without rechecking the blueprint cache on every call.
Need to design a non-hacky way to distinguish a service and a spell, I think. It will be needed not only for this metrics collection thing but also for rewriting the registry and other built-in services as spells.