-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(http): Added http healthcheck endpoint #1725
Conversation
NET-421 Add /health HTTP endpoint to rust-peer
I really-really need this to be able to have control over automated deployments. Update one rust-peer at a time, notify on failure, roll-back etc. It could return 200 code if rust-peer joined kademlia and all builtin services are started with some additional information in plain text like aquavm version, rust-peer version etc |
b397bd9
to
0f11ca4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I don't quite get why we do healthcheck HTTP API and not use Prometheus
Co-authored-by: folex <0xdxdy@gmail.com>
Co-authored-by: folex <0xdxdy@gmail.com>
Co-authored-by: Aleksey Proshutisnkiy <justprosh@users.noreply.github.com>
Co-authored-by: Aleksey Proshutisnkiy <justprosh@users.noreply.github.com>
a3c43f3
to
1d8a134
Compare
Description
Added health check HTTP endpoint
Motivation
For now it is not possible to understand the status of node, it can be fully or partially broken. Health check allows to define critical checks to determine a system status.
Proposed Changes
Screenshots (if applicable)
Additional Notes
Also was fixed metric for bootstrap disconnected. it was applied for all disconnected events, not only bootstrap addresses.
Checklist
Reviewer Checklist