Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): fix http port argument #1751

Merged
merged 3 commits into from
Aug 11, 2023
Merged

fix(config): fix http port argument #1751

merged 3 commits into from
Aug 11, 2023

Conversation

gurinderu
Copy link
Contributor

@gurinderu gurinderu commented Aug 10, 2023

Description

Renamed metric-port argument to http-port

Motivation

Lost configuration update. Metrics port was renamed to more generic HTTP port

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@gurinderu gurinderu marked this pull request as ready for review August 10, 2023 11:09
Copy link
Member

@justprosh justprosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the default config from nox-distro repo?

@nahsi nahsi added the e2e Run e2e workflow label Aug 10, 2023
@gurinderu
Copy link
Contributor Author

Should we update the default config from nox-distro repo?

I have no idea. It has the wrong property prometheus_port = 18080. This is also a default value. It should not affect somebody

@folex
Copy link
Member

folex commented Aug 10, 2023

Should we update the default config from nox-distro repo?

Yes, since it's a renaming of a config field, we gotta reflect it in the default config. @gurinderu please.

@gurinderu gurinderu merged commit 84c4315 into master Aug 11, 2023
15 checks passed
@gurinderu gurinderu deleted the http-port-fix branch August 11, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants