Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(worker): allow to add alias for worker creator #1779

Merged
merged 5 commits into from
Sep 6, 2023

Conversation

justprosh
Copy link
Member

@justprosh justprosh commented Sep 6, 2023

Description

Allow to add aliases on worker for worker creator.

Motivation

Previously, it was possible to add an alias for management peer id and worker itself, but after we moved Srv.add_alias("worker-spell"..) from installation spell to decider, it became impossible for workers deploy to work properly with latest installation spell because you can't add alias for spell after worker creation.

Related Issue(s)

[Cite any related issues or feature requests here, using GitHub issue links.]

Proposed Changes

  • allow to add alias for worker creator
  • finally use key manager in particle app services

Screenshots (if applicable)

[Add any relevant screenshots or animated GIFs to showcase the changes.]

Additional Notes

[Provide any additional information or context that may be helpful for the reviewer.]

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@justprosh justprosh added the e2e Run e2e workflow label Sep 6, 2023
@justprosh justprosh merged commit ada1276 into master Sep 6, 2023
14 checks passed
@justprosh justprosh deleted the add_alias_direct_deploy branch September 6, 2023 17:20
@@ -108,6 +108,8 @@ pub enum ServiceError {
#[source]
err: std::io::Error,
},
#[error("Internal error, smth bad happened: {0}")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants