Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(system-services): refactor deployer + fix [NET-586] #1859

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Conversation

justprosh
Copy link
Member

Description

Update system spells KV in case of only init_data change. + refactoring

Motivation

Deployer didn't update Decider KV in case of only api_endpoint update in init_data

Proposed Changes

  • update script, init_data, and trigger config on each restart (it costs the same to compare everything and then update, but it makes code more complicated)
  • stop nox in case of failure to redeploy system spell

Checklist

  • The code follows the project's coding conventions and style guidelines.
  • All tests related to the changes have passed successfully.
  • Documentation has been updated to reflect the changes (if applicable).
  • All new and existing unit tests have passed.
  • I have self-reviewed my code and ensured its quality.
  • I have added/updated necessary comments to aid understanding.

Reviewer Checklist

  • Code has been reviewed for quality and adherence to guidelines.
  • Tests have been reviewed and are sufficient to validate the changes.
  • Documentation has been reviewed and is up to date.
  • Any questions or concerns have been addressed.

@linear
Copy link

linear bot commented Oct 27, 2023

NET-586 Changing RPC url in nox requires wipe of service storage

If nox was started with persistent storage changing

    FLUENCE_ENV_CONNECTOR_API_ENDPOINT

does nothing. Nox is still using old value that it was first started with

@justprosh justprosh added the e2e Run e2e workflow label Oct 27, 2023
@justprosh justprosh merged commit 78b0a46 into master Oct 30, 2023
21 checks passed
@justprosh justprosh deleted the decider_test branch October 30, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants