fix(metrics): separate a avm call time & interpretation time metrics #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NET-626 Use `execution_time` from AVMOutcome
Report it as a separate metric Compare against old Interpretation Time metric |
gurinderu
changed the title
justprosh
approved these changes
Nov 10, 2023
kmd-fl
reviewed
Nov 10, 2023
| let call_time_sec = Histogram::new(execution_time_buckets()); | ||
| sub_registry.register( | ||
| "avm_call_time_sec", | ||
| "Distribution of time it took to run the avm call once", |
There was a problem hiding this comment.
I don't see much difference between "time it took to run the interpreter once" and "time it took to run the avm call once". Can you write clearer ones?
There was a problem hiding this comment.
avm call time is an interpratation time + saving data on disk
There was a problem hiding this comment.
cool, would be nice to reflect it in the metrics descriptions, wdyt?
folex
approved these changes
Nov 10, 2023
gurinderu
added a commit
that referenced
this pull request
Nov 14, 2023
…1893) * fix(metrics): separate a avm call time & interperation time metrics * fix comment * fix comment * improve fmt * improve desc * add retries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separate an AVM call time & interpretation time metrics.
Motivation
For now, the interpretation time metric shows as the interpretation time + disk IO time. We want to expose information without IO to clearly understand the AVM behavior.
Proposed Changes
interpretation_time becomes time from AVM metrics and shows only interpretation.
call_time is a previous interpretation_time.
Checklist
Reviewer Checklist