feat: implement batching #2291
feat: implement batching #2291
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -806,6 +816,14 @@ impl ChainConnector for HttpChainConnector { | |||
| } | |||
| } | |||
|
|
|||
| fn parse_str_field(value: Option<Value>, field: &str) -> eyre::Result<String> { | |||
| value | |||
| .ok_or(eyre!("Field {} not found in response", field))? | |||
There was a problem hiding this comment.
It should be .ok_or_else(|| eyre!(...)) everywhere, probably.
There was a problem hiding this comment.
it should be enum without eyre)
| } | ||
| // } else if let Err(err) = self.submit_mocked_proofs().await { |
| .and_modify(|c| { | ||
| *c = c.add(Uint::from(1)); | ||
| }) | ||
| .or_insert(Uint::from(1)), |
There was a problem hiding this comment.
IMHO
let proof_something = self.proof_counter.entry(cu_id).or_insert(Uint::ZERO);
*proof_something = *proof_something.add(Uint::from(1));
let proof_id = Uint::from(*proof_something);
would be more explicit.
There was a problem hiding this comment.
The top-level Uint::from, is it really needed?
| let local_nonce = LocalNonce::random(); | ||
| self.submit_proof(CCProof::new(proof_id, local_nonce, unit, result_hash)) | ||
| .await?; | ||
| // /// Submit Mocked Proofs for all active compute units. |
| tracing::debug!(target: "chain-listener", "Polling proofs after {:?}", last_known_proofs); | ||
| measured_request( | ||
| &self.metrics, | ||
| async { ccp_client.get_proofs_after(last_known_proofs, PROOF_POLL_LIMIT) } |
There was a problem hiding this comment.
The async { X }.await construction may be replaced by just X. Here and elsewhere.
| @@ -11,6 +11,10 @@ on: | |||
| description: "Cargo dependencies map" | |||
| type: string | |||
| default: "null" | |||
| secrets: | |||
There was a problem hiding this comment.
Why did you change that in this pr?
There was a problem hiding this comment.
it was done by @enjenjenje because of private repo deps
| @@ -468,25 +473,28 @@ impl HttpChainConnector { | |||
| gas_limit: Uint256::from_le_bytes(&gas_limit.to_le_bytes_vec()), | |||
| to: to.parse()?, | |||
| value: 0u32.into(), | |||
| data, | |||
| data: data.clone(), | |||
There was a problem hiding this comment.
Data can be a pretty big, probably it is better to apply hex::decode before this line and do not use cloning ?
| } | ||
|
|
||
| async fn persist(&self) { | ||
| let backoff = ExponentialBackoff { |
There was a problem hiding this comment.
Why do we need a backoff for the persistence ?
| .ok_or(eyre::eyre!("number field not found; got {json}"))? | ||
| .to_string(); | ||
|
|
||
| Ok(Self { |
There was a problem hiding this comment.
The type may be deserialized from a Value with serde in more declarative manner.
https://docs.rs/serde_json/latest/serde_json/fn.from_value.html
No description provided.