-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builtins)!: add worker.list, move spell.list to worker scope [fixes NET-401 NET-435] #1537
Conversation
@@ -80,7 +80,12 @@ impl Sorcerer { | |||
} | |||
|
|||
async fn resubscribe_spells(&self) { | |||
for (spell_id, _) in self.spell_storage.get_registered_spells() { | |||
for spell_id in self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible that a single spell exists on several workers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if not, please add a comment on why. It's not clear how you guarantee that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is guaranteed by service
structure, it has only one field worker_id
and it is the only source of truth about worker_id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know where to put this comment
No description provided.