Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spells): start resubscribed spells scheduling after full node initialization [fixes NET-459] #1592

Merged
merged 5 commits into from
Apr 28, 2023
Merged

fix(spells): start resubscribed spells scheduling after full node initialization [fixes NET-459] #1592

merged 5 commits into from
Apr 28, 2023

Conversation

kmd-fl
Copy link
Contributor

@kmd-fl kmd-fl commented Apr 27, 2023

No description provided.

folex
folex reviewed Apr 28, 2023
View reviewed changes
particle-node/src/node.rs Outdated Show resolved Hide resolved
folex
folex reviewed Apr 28, 2023
View reviewed changes
Copy link
Member

@folex folex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This is a very important PR that will make nox more stable.

Just a few things to change before the merge.

@kmd-fl kmd-fl changed the title fix(spells): start resubscribed spells scheduling after full node initialization fix(spells): start resubscribed spells scheduling after full node initialization [fixes NET-459] Apr 28, 2023
@linear
Copy link

linear bot commented Apr 28, 2023

NET-459 Add start_scheduler command to SpellBus

@folex folex added the e2e Run e2e workflow label Apr 28, 2023
@folex folex merged commit 1016f36 into master Apr 28, 2023
@folex folex deleted the fix-spell-bus-start branch April 28, 2023 16:55
@fluencebot fluencebot mentioned this pull request Apr 28, 2023
Merged
@fluencebot fluencebot mentioned this pull request Jun 22, 2023
Merged
@fluencebot fluencebot mentioned this pull request Jul 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurinderu gurinderu gurinderu left review comments

@folex folex folex approved these changes

@justprosh justprosh Awaiting requested review from justprosh

Assignees
No one assigned
Labels
e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kmd-fl @gurinderu @folex