Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for new decoders of Fluendo #169

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Add support for new decoders of Fluendo #169

merged 1 commit into from
Apr 22, 2024

Conversation

carlosfg-flu
Copy link
Contributor

@carlosfg-flu carlosfg-flu commented Mar 28, 2024 •
edited
Loading

Fluendo divided their decoders by backend and codec, so where before there were just fluhwvadec or fluhwvah264dec, now there are fluhwva{backend}{codec} (fluhwvavaapih264dec for example).

This commit generate the types for this decoders programmatically, to reduce the amount of code required otherwise.

Decoders generated:

Fluendo-H.264-DXVA2-Gst1.0: Fluendo H.264 DXVA2 decoder for GStreamer 1.0
Fluendo-H.264-VAAPI-Gst1.0: Fluendo H.264 VAAPI decoder for GStreamer 1.0
Fluendo-H.264-VDA-Gst1.0: Fluendo H.264 VDA decoder for GStreamer 1.0
Fluendo-H.264-VDPAU-Gst1.0: Fluendo H.264 VDPAU decoder for GStreamer 1.0
Fluendo-H.264-VT-Gst1.0: Fluendo H.264 VT decoder for GStreamer 1.0
Fluendo-H.265-byte-stream-au-DXVA2-Gst1.0: Fluendo H.265-byte-stream-au DXVA2 decoder for GStreamer 1.0
Fluendo-H.265-byte-stream-au-VAAPI-Gst1.0: Fluendo H.265-byte-stream-au VAAPI decoder for GStreamer 1.0
Fluendo-H.265-byte-stream-au-VDA-Gst1.0: Fluendo H.265-byte-stream-au VDA decoder for GStreamer 1.0
Fluendo-H.265-byte-stream-au-VDPAU-Gst1.0: Fluendo H.265-byte-stream-au VDPAU decoder for GStreamer 1.0
Fluendo-H.265-byte-stream-au-VT-Gst1.0: Fluendo H.265-byte-stream-au VT decoder for GStreamer 1.0
Fluendo-H.265-byte-stream-nal-DXVA2-Gst1.0: Fluendo H.265-byte-stream-nal DXVA2 decoder for GStreamer 1.0
Fluendo-H.265-byte-stream-nal-VAAPI-Gst1.0: Fluendo H.265-byte-stream-nal VAAPI decoder for GStreamer 1.0
Fluendo-H.265-byte-stream-nal-VDA-Gst1.0: Fluendo H.265-byte-stream-nal VDA decoder for GStreamer 1.0
Fluendo-H.265-byte-stream-nal-VDPAU-Gst1.0: Fluendo H.265-byte-stream-nal VDPAU decoder for GStreamer 1.0
Fluendo-H.265-byte-stream-nal-VT-Gst1.0: Fluendo H.265-byte-stream-nal VT decoder for GStreamer 1.0
Fluendo-H.265-hev1-au-DXVA2-Gst1.0: Fluendo H.265-hev1-au DXVA2 decoder for GStreamer 1.0
Fluendo-H.265-hev1-au-VAAPI-Gst1.0: Fluendo H.265-hev1-au VAAPI decoder for GStreamer 1.0
Fluendo-H.265-hev1-au-VDA-Gst1.0: Fluendo H.265-hev1-au VDA decoder for GStreamer 1.0
Fluendo-H.265-hev1-au-VDPAU-Gst1.0: Fluendo H.265-hev1-au VDPAU decoder for GStreamer 1.0
Fluendo-H.265-hev1-au-VT-Gst1.0: Fluendo H.265-hev1-au VT decoder for GStreamer 1.0
Fluendo-H.265-hev1-nal-DXVA2-Gst1.0: Fluendo H.265-hev1-nal DXVA2 decoder for GStreamer 1.0
Fluendo-H.265-hev1-nal-VAAPI-Gst1.0: Fluendo H.265-hev1-nal VAAPI decoder for GStreamer 1.0
Fluendo-H.265-hev1-nal-VDA-Gst1.0: Fluendo H.265-hev1-nal VDA decoder for GStreamer 1.0
Fluendo-H.265-hev1-nal-VDPAU-Gst1.0: Fluendo H.265-hev1-nal VDPAU decoder for GStreamer 1.0
Fluendo-H.265-hev1-nal-VT-Gst1.0: Fluendo H.265-hev1-nal VT decoder for GStreamer 1.0
Fluendo-H.265-hvc1-au-DXVA2-Gst1.0: Fluendo H.265-hvc1-au DXVA2 decoder for GStreamer 1.0
Fluendo-H.265-hvc1-au-VAAPI-Gst1.0: Fluendo H.265-hvc1-au VAAPI decoder for GStreamer 1.0
Fluendo-H.265-hvc1-au-VDA-Gst1.0: Fluendo H.265-hvc1-au VDA decoder for GStreamer 1.0
Fluendo-H.265-hvc1-au-VDPAU-Gst1.0: Fluendo H.265-hvc1-au VDPAU decoder for GStreamer 1.0
Fluendo-H.265-hvc1-au-VT-Gst1.0: Fluendo H.265-hvc1-au VT decoder for GStreamer 1.0
Fluendo-H.265-hvc1-nal-DXVA2-Gst1.0: Fluendo H.265-hvc1-nal DXVA2 decoder for GStreamer 1.0
Fluendo-H.265-hvc1-nal-VAAPI-Gst1.0: Fluendo H.265-hvc1-nal VAAPI decoder for GStreamer 1.0
Fluendo-H.265-hvc1-nal-VDA-Gst1.0: Fluendo H.265-hvc1-nal VDA decoder for GStreamer 1.0
Fluendo-H.265-hvc1-nal-VDPAU-Gst1.0: Fluendo H.265-hvc1-nal VDPAU decoder for GStreamer 1.0
Fluendo-H.265-hvc1-nal-VT-Gst1.0: Fluendo H.265-hvc1-nal VT decoder for GStreamer 1.0

Issue: OCP_5454

@carlosfg-flu carlosfg-flu force-pushed the OCP-5454 branch 6 times, most recently from c413164 to c9a5822 Compare April 4, 2024 11:36
@carlosfg-flu carlosfg-flu force-pushed the OCP-5454 branch 4 times, most recently from 78d3480 to 8379cb8 Compare April 9, 2024 08:51
@carlosfg-flu
Add support for new decoders of Fluendo
83c97c0 
Fluendo divided their decoders by backend and codec, so where before there
were just `fluhwvadec` or `fluhwvah264dec`, now there are
`fluhwva{backend}{codec}` (`fluhwvavaapih264dec` for example).

Issue: OCP_5454
@carlosfg-flu carlosfg-flu marked this pull request as ready for review April 18, 2024 07:28
mdimopoulos
mdimopoulos approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@mdimopoulos mdimopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@carlosfg-flu carlosfg-flu changed the base branch from master to OCP-5012-split April 22, 2024 10:07
@carlosfg-flu carlosfg-flu merged commit fe68b50 into OCP-5012-split Apr 22, 2024
3 checks passed
@carlosfg-flu carlosfg-flu deleted the OCP-5454 branch April 22, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdimopoulos mdimopoulos mdimopoulos approved these changes

@dememax dememax Awaiting requested review from dememax

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carlosfg-flu @mdimopoulos