Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation supports nested use #3

Closed
xinyao27 opened this issue Aug 2, 2019 · 2 comments
Closed

Navigation supports nested use #3

xinyao27 opened this issue Aug 2, 2019 · 2 comments
Labels
feature New features of the future
Projects
Todo List (1.0)

Comments

@xinyao27
Copy link
Collaborator

xinyao27 commented Aug 2, 2019 •
edited

Need to refactor Navigation, the refactoring content is as follows:

  1. Item prop id renamed to key
  2. The new subcomponent ItemGroup is used to support the embedding of Item
  3. fluent-ui.com Refactor with the new Navigation
  4. Pull out the Item component into a public component
@xinyao27 xinyao27 created this issue from a note in Todo List (1.0) (In progress) Aug 2, 2019
xinyao27 added a commit that referenced this issue Aug 2, 2019
@xinyao27
feat(Navigation): The new subcomponent ItemGroup is used to support t…
1f074e9 
…he embedding of Item (#3)

TODO: 1. horizontal support 2. Transition bug

#3
xinyao27 added a commit that referenced this issue Aug 2, 2019
@xinyao27
docs(Navigation): The new subcomponent ItemGroup is used to support t…
39b1639 
…he embedding of Item (#3)

fluent-ui.com Refactor with the new Navigation

#3
@xinyao27
Copy link
Collaborator Author

xinyao27 commented Aug 3, 2019

The above problem has been solved. There is still a horizontal prop left to be adapted.

@xinyao27
Copy link
Collaborator Author

xinyao27 commented Aug 8, 2019

A new point that needs to be refactored:

  • The icon of the Item is carried by a single prop.

xinyao27 added a commit that referenced this issue Aug 9, 2019
@xinyao27
feat(Item): The icon of the Item is carried by a single prop. (#3)
d089b57 
#3
xinyao27 added a commit that referenced this issue Aug 11, 2019
@xinyao27
feat(ItemGroup): Complete basic content (#3)
6ba7e02 
#3
xinyao27 added a commit that referenced this issue Aug 11, 2019
@xinyao27
fix(ItemGroup): Fix the arrow shows the problem
8cc09a3 
#3
@xinyao27 xinyao27 moved this from In progress to Done in Todo List (1.0) Aug 11, 2019
@xinyao27 xinyao27 added the feature New features of the future label Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New features of the future
Projects
Todo List (1.0)
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xinyao27