Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new version of fluentd does not auto load core libs #10

Closed
wants to merge 8 commits into from

Conversation

jescarri
Copy link
Contributor

No description provided.

Jesus Carrillo and others added 3 commits August 29, 2016 13:28
…ib/fluent/plugin/systemd/pos_writer.rb to die with unexpected error error=uninitialized constant Fluent::Input
…ib/fluent/plugin/systemd/pos_writer.rb to die with unexpected error error=uninitialized constant Fluent::Input
…ib/fluent/plugin/systemd/pos_writer.rb to die with unexpected error error=uninitialized constant Fluent::Input
@reevoo-samuel
Copy link

If you're new, read the guidelines.

Good code is tested, designed for change, easy to understand
and able to cope when things go wrong.

Good pull requests are descriptive, small and short-lived.

For the Author

  • Description explains what you have done and why.
  • Tests have been written (or you have explained why you don't need
    tests).
  • Documentation/comments have been added/updated.

For the Reviewer

  • The code is well-designed and able to cope with change.
  • The code is easy to understand.
  • Tests cover happy and unhappy paths in the code.
  • Tests are green on CI (or pulled/tested on your machine).

@errm
Copy link
Collaborator

errm commented Aug 30, 2016

Thanks for the PR . . . I have a few nits but it looks good thanks :)

@@ -31,6 +32,7 @@ def start
end

def shutdown
super
@running = false
@thread.join
pos_writer.shutdown
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we call super at the end of shutdown or the pos_writer will never get shutdown.

@errm
Copy link
Collaborator

errm commented Aug 30, 2016

Ok Merged

@errm errm closed this Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants