-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new version of fluentd does not auto load core libs #10
Conversation
…ib/fluent/plugin/systemd/pos_writer.rb to die with unexpected error error=uninitialized constant Fluent::Input
…ib/fluent/plugin/systemd/pos_writer.rb to die with unexpected error error=uninitialized constant Fluent::Input
…ib/fluent/plugin/systemd/pos_writer.rb to die with unexpected error error=uninitialized constant Fluent::Input
If you're new, read the guidelines. Good code is tested, designed for change, easy to understand Good pull requests are descriptive, small and short-lived. For the Author
For the Reviewer
|
Thanks for the PR . . . I have a few nits but it looks good thanks :) |
@@ -31,6 +32,7 @@ def start | |||
end | |||
|
|||
def shutdown | |||
super | |||
@running = false | |||
@thread.join | |||
pos_writer.shutdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we call super at the end of shutdown or the pos_writer will never get shutdown.
Ok Merged |
No description provided.