Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

out_tcp2: register new plugin #5

Closed
wants to merge 1 commit into from
Closed

out_tcp2: register new plugin #5

wants to merge 1 commit into from

Conversation

asquare14
Copy link
Contributor

@asquare14 asquare14 commented Mar 23, 2020 •
edited

Signed-off-by: Atibhi Agrawal atibhi.a@gmail.com

@asquare14 asquare14 force-pushed the master branch 4 times, most recently from 185d530 to 0f665bc Compare March 25, 2020 15:59
edsiper
edsiper reviewed Mar 26, 2020
View reviewed changes
Copy link
Member

@edsiper edsiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. Please add more details in the README.md of this plugin explaining how it works. This is the documentation for a developer that aims to learn how to create plugins

out_tcp2/tcp2.c Outdated Show resolved Hide resolved
out_tcp2/tcp2.c Show resolved Hide resolved
@asquare14
out_tcp2: register new plugin
c83d745 
Signed-off-by: Atibhi Agrawal <atibhi.a@gmail.com>
@asquare14 asquare14 requested a review from edsiper March 27, 2020 14:10
@asquare14
Copy link
Contributor Author

@edsiper Please review

@asquare14
Copy link
Contributor Author

@edsiper could u please review

@asquare14 asquare14 closed this May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edsiper edsiper Awaiting requested review from edsiper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asquare14 @edsiper