Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #52

Closed
elfring opened this issue Mar 3, 2016 · 2 comments
Closed

reserved identifier violation #52

elfring opened this issue Mar 3, 2016 · 2 comments

Comments

@elfring
Copy link

elfring commented Mar 3, 2016

I would like to point out that an identifier like "__flb_config_verbose" does eventually not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?
@edsiper
Copy link
Member

edsiper commented Mar 3, 2016

Agree, that's something should go away, I will make it configurable from the lib context. I will keep this issue open until it get fixed.

thanks for the reviews!

@elfring
Copy link
Author

elfring commented Mar 16, 2016

Thanks for your small source code improvement.

allamand pushed a commit to allamand/fluent-bit that referenced this issue Oct 26, 2020
@sonofachamp
Merge pull request fluent#52 from sonofachamp/codeowners
69b5974 
Add CODEOWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edsiper @elfring