Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated k8s-nginx-ingress parser for NGINX Controller #1869

Merged
merged 2 commits into from Feb 12, 2020

Conversation

arjun921
Copy link
Contributor

Updated parser to support latest helm release
Helm Version: nginx-ingress-1.28.0
App Version: 0.26.2

Updated parser to support latest helm release
Helm Version: `nginx-ingress-1.28.0`
App Version: `0.26.2 `

Signed-off-by: Arjun Sunil <arjun921@gmail.com>
@arjun921
Copy link
Contributor Author

arjun921 commented Jan 25, 2020

@PettitWesley What can I do to fix all checks?

@arjun921 arjun921 changed the title Updated k8s-nginx-ingress Updated k8s-nginx-ingress parser for NGINX Controller Jan 25, 2020
@PettitWesley
Copy link
Contributor

PettitWesley commented Jan 25, 2020

@arjun921 I think the travis failure is just a timeout issue, if you re-push your commit it should re-run and might be fine.

The App Veyor build can't be fixed till this is merged: #1856

@PettitWesley
Copy link
Contributor

Also, not certain (may be these repos get synced on a release?), but I think you should update the parser here too: https://github.com/fluent/fluent-bit-docker-image/tree/1.3

@edsiper
Copy link
Member

edsiper commented Jan 25, 2020

@arjun921 would you please also attach a https://rubular.com short link with data sample and the regex ?, that would be useful for the record.

@edsiper edsiper added the waiting-for-user Waiting for more information, tests or requested changes label Jan 25, 2020
@arjun921
Copy link
Contributor Author

Also, not certain (may be these repos get synced on a release?), but I think you should update the parser here too: https://github.com/fluent/fluent-bit-docker-image/tree/1.3

I will update it for sure!

@arjun921 would you please also attach a https://rubular.com short link with data sample and the regex ?, that would be useful for the record.

Here you go @edsiper
https://rubular.com/r/P8zgLD5K73fp2n

I'll add it as a comment too in the parser for reference.

Signed-off-by: Arjun Sunil <arjun921@gmail.com>
@arjun921
Copy link
Contributor Author

arjun921 commented Feb 4, 2020

@edsiper @PettitWesley Any chance we could merge this now 😅?

@edsiper edsiper merged commit b50be28 into fluent:master Feb 12, 2020
@edsiper
Copy link
Member

edsiper commented Feb 12, 2020

thanks

@robberlang
Copy link
Contributor

Hi, the new regular expression here is missing the user field.

@PettitWesley
Copy link
Contributor

@robberlang Could you submit a pull request to add that field? Thanks!

@arjun921
Copy link
Contributor Author

arjun921 commented Feb 22, 2020

@robberlang Which version of Nginx Ingress Controller are you using?
The parser was breaking for me with the latest version as of the time of raising this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-user Waiting for more information, tests or requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants