Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_s3: New plugin for Amazon S3 #2583

Merged
merged 8 commits into from
Sep 25, 2020

Conversation

PettitWesley
Copy link
Contributor

#1004


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

Documentation

  • Documentation required for this feature

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Meghna Prabhu <meghnapr@amazon.com>
@edsiper
Copy link
Member

edsiper commented Sep 25, 2020

PettitWesley and others added 7 commits September 24, 2020 22:52
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
 - use new fstore API for buffer management
 - register plugin flags
 - config: change configmap for TIME and SIZE value types
 - config: rename chunk_buffer_dir -> store_dir
 - fix leaks on exceptions
 - use field to 'lock' chunks, instead of temporary node deletion
 - others adjustments

note: still work in process.

Signed-off-by: Eduardo Silva <eduardo@treasure-data.com>
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
@PettitWesley
Copy link
Contributor Author

@edsiper Should be fixed now

@edsiper edsiper merged commit 10ee6d3 into fluent:master Sep 25, 2020
@edsiper
Copy link
Member

edsiper commented Sep 25, 2020

thanks!

@avdhoot
Copy link

avdhoot commented Sep 30, 2020

@PettitWesley Thank for all effort. hope it will get release soon. Will it support AssumeRoleWithWebIdentity. This will helpful in k8s environment. more --> https://aws.amazon.com/blogs/opensource/introducing-fine-grained-iam-roles-service-accounts/

@PettitWesley
Copy link
Contributor Author

@avdhoot The core Fluent Bit AWS credential library I built supports EKS IAM Roles for Service Accounts. So all AWS outputs support that.

See my comment here for a pre-release version: #1004 (comment)

If you have time to test it out and verify that everything works that'd be awesome!

@PettitWesley PettitWesley deleted the out_s3_first_merge branch September 30, 2020 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants