Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_s3: fix NULL dereference when upload_id is unset #3841

Merged

Commits on Jul 27, 2021

  1. out_s3: fix NULL dereference when upload_id is unset

    When upload_id is not set in create_multipart_upload() (which can occur
    in some failure modes), subsequent retries will segfault when checking
    this ID in complete_multipart_upload().
    
    This commit simply checks that the upload ID has been set and returns
    the usual error code instead of crashing if not. It also logs an error
    message for the user.
    
    Discussed in fluent#3838.
    
    Signed-off-by: Aaron Jacobs <aaron.jacobs@crescendotechnology.com>
    atheriel committed Jul 27, 2021
    Copy the full SHA
    398cd06 View commit details
    Browse the repository at this point in the history