lib: snappy: don't require c++ #7253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasDevoogdt
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
ThomasDevoogdt
force-pushed
the
bugfix/no-c++
branch
from
2c65dcf
to
57c4b4f
Compare
1 task
leonardo-albertovich
previously approved these changes
Apr 24, 2023
1 task
snappy is written in c, so only enforce a c compiler The CMakeLists.txt is not part of the original repo [1], so nothing to upstream. [1] https://github.com/andikleen/snappy-c Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
ThomasDevoogdt
force-pushed
the
bugfix/no-c++
branch
from
57c4b4f
to
5dbcdfe
Compare
ThomasDevoogdt
changed the title
leonardo-albertovich
approved these changes
Apr 27, 2023
|
@leonardo-albertovich, can you also merge this PR or assign it to someone that can. I'm not affiliated with fluent-bit, I just want to get rid of the custom buildroot patches. (Fyi Buildroot is a tool to generate embedded Linux systems, a bit the counterpart of Yocto) |
ThomasDevoogdt
added a commit
to ThomasDevoogdt/buildroot
that referenced
this pull request
May 17, 2023
Fluent Bit v2.1 is the start of the new stable series of the project.
- Release Notes:
https://fluentbit.io/announcements/v2.1.0/
https://fluentbit.io/announcements/v2.1.1/
https://fluentbit.io/announcements/v2.1.2/
No release notes yet for 2.1.3, but contains this
list of upstreamed patches:
fluent/fluent-bit#7266
fluent/fluent-bit#7254
fluent/fluent-bit#7253
So the old patches can be dropped.
Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
ThomasDevoogdt
added a commit
to ThomasDevoogdt/buildroot
that referenced
this pull request
May 22, 2023
Fluent Bit v2.1 is the start of the new stable series of the project. Release Notes: https://fluentbit.io/announcements/v2.1.0/ https://fluentbit.io/announcements/v2.1.1/ https://fluentbit.io/announcements/v2.1.2/ https://fluentbit.io/announcements/v2.1.3/ Fluent Bit v2.1.3 contains this list of upstreamed patches: fluent/fluent-bit#7266 fluent/fluent-bit#7254 fluent/fluent-bit#7253 So the old patches can be dropped. Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
ThomasDevoogdt
added a commit
to ThomasDevoogdt/buildroot
that referenced
this pull request
Jun 10, 2023
Fluent Bit v2.1 is the start of the new stable series of the project. Release Notes: https://fluentbit.io/announcements/v2.1.0/ https://fluentbit.io/announcements/v2.1.1/ https://fluentbit.io/announcements/v2.1.2/ https://fluentbit.io/announcements/v2.1.3/ https://fluentbit.io/announcements/v2.1.4/ Fluent Bit v2.1.4 contains this list of upstreamed patches: fluent/fluent-bit#7266 fluent/fluent-bit#7254 fluent/fluent-bit#7253 So the old patches can be dropped. Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
ThomasDevoogdt
added a commit
to ThomasDevoogdt/buildroot
that referenced
this pull request
Jul 23, 2023
Fluent Bit v2.1 is the start of the new stable series of the project. Release Notes: https://fluentbit.io/announcements/v2.1.0/ https://fluentbit.io/announcements/v2.1.1/ https://fluentbit.io/announcements/v2.1.2/ https://fluentbit.io/announcements/v2.1.3/ https://fluentbit.io/announcements/v2.1.4/ Fluent Bit v2.1.4 contains this list of upstreamed patches: fluent/fluent-bit#7266 fluent/fluent-bit#7254 fluent/fluent-bit#7253 So the old patches can be dropped. Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
ThomasDevoogdt
added a commit
to ThomasDevoogdt/buildroot
that referenced
this pull request
Jul 23, 2023
Fluent Bit v2.1 is the start of the new stable series of the project. Release Notes: https://fluentbit.io/announcements/v2.1.0/ https://fluentbit.io/announcements/v2.1.1/ https://fluentbit.io/announcements/v2.1.2/ https://fluentbit.io/announcements/v2.1.3/ https://fluentbit.io/announcements/v2.1.4/ https://fluentbit.io/announcements/v2.1.5/ https://fluentbit.io/announcements/v2.1.6/ https://fluentbit.io/announcements/v2.1.7/ Fluent Bit v2.1.4 contains this list of upstreamed patches: fluent/fluent-bit#7266 fluent/fluent-bit#7254 fluent/fluent-bit#7253 So the old patches can be dropped. Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Jul 23, 2023
Fluent Bit v2.1 is the start of the new stable series of the project. Release Notes: https://fluentbit.io/announcements/v2.1.0/ https://fluentbit.io/announcements/v2.1.1/ https://fluentbit.io/announcements/v2.1.2/ https://fluentbit.io/announcements/v2.1.3/ https://fluentbit.io/announcements/v2.1.4/ https://fluentbit.io/announcements/v2.1.5/ https://fluentbit.io/announcements/v2.1.6/ https://fluentbit.io/announcements/v2.1.7/ Fluent Bit v2.1.7 contains this list of upstreamed patches: fluent/fluent-bit#7266 fluent/fluent-bit#7254 fluent/fluent-bit#7253 So the old patches can be dropped. Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
citral23
pushed a commit
to citral23/buildroot
that referenced
this pull request
Sep 18, 2023
Fluent Bit v2.1 is the start of the new stable series of the project. Release Notes: https://fluentbit.io/announcements/v2.1.0/ https://fluentbit.io/announcements/v2.1.1/ https://fluentbit.io/announcements/v2.1.2/ https://fluentbit.io/announcements/v2.1.3/ https://fluentbit.io/announcements/v2.1.4/ https://fluentbit.io/announcements/v2.1.5/ https://fluentbit.io/announcements/v2.1.6/ https://fluentbit.io/announcements/v2.1.7/ Fluent Bit v2.1.7 contains this list of upstreamed patches: fluent/fluent-bit#7266 fluent/fluent-bit#7254 fluent/fluent-bit#7253 So the old patches can be dropped. Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't require C++ for the snappy lib.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.