ci: set a version for Chocolatey #7588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #7574 setting Chocolatey version to 1.4.0 since the version doesn't require .NET 4.8 Signed-off-by: Celalettin Calis <celalettin@calyptia.com>
celalettin1286
requested review from
niedbalski and
patrick-stephens
as code owners
|
I've triggered the full build to see if it resolves things. |
|
@celalettin1286 please update the https://github.com/fluent/fluent-bit/blob/master/.github/workflows/pr-image-tests.yaml workflow so it builds the Windows containers too - that will then verify your change as well. |
patrick-stephens
added
Windows
Signed-off-by: celalettin1286 <celalettin@calyptia.com>
Signed-off-by: celalettin1286 <celalettin@calyptia.com>
Signed-off-by: celalettin1286 <celalettin@calyptia.com>
patrick-stephens
previously approved these changes
Jun 19, 2023
Signed-off-by: celalettin1286 <celalettin@calyptia.com>
Signed-off-by: celalettin1286 <celalettin@calyptia.com>
patrick-stephens
approved these changes
Jun 19, 2023
celalettin1286
added a commit
that referenced
this pull request
Jun 21, 2023
* ci: set a version for Chocolatey fixes #7574 setting Chocolatey version to 1.4.0 since the version doesn't require .NET 4.8 Signed-off-by: Celalettin Calis <celalettin@calyptia.com> * ci: added windows tests to pr image tests Signed-off-by: celalettin1286 <celalettin@calyptia.com> * ci: changed build method Signed-off-by: celalettin1286 <celalettin@calyptia.com> * ci: changed runner to windows 2019 Signed-off-by: celalettin1286 <celalettin@calyptia.com> * ci: add matrix for windows 2019 and 2022 Signed-off-by: celalettin1286 <celalettin@calyptia.com> * change job title Signed-off-by: celalettin1286 <celalettin@calyptia.com> --------- Signed-off-by: Celalettin Calis <celalettin@calyptia.com> Signed-off-by: celalettin1286 <celalettin@calyptia.com>
celalettin1286
added a commit
that referenced
this pull request
Jun 21, 2023
* ci: set a version for Chocolatey fixes #7574 setting Chocolatey version to 1.4.0 since the version doesn't require .NET 4.8 * ci: added windows tests to pr image tests * ci: changed build method * ci: changed runner to windows 2019 * ci: add matrix for windows 2019 and 2022 * change job title --------- Signed-off-by: Celalettin Calis <celalettin@calyptia.com> Signed-off-by: celalettin1286 <celalettin@calyptia.com>
leonardo-albertovich
pushed a commit
that referenced
this pull request
Jul 17, 2023
* ci: set a version for Chocolatey fixes #7574 setting Chocolatey version to 1.4.0 since the version doesn't require .NET 4.8 Signed-off-by: Celalettin Calis <celalettin@calyptia.com> * ci: added windows tests to pr image tests Signed-off-by: celalettin1286 <celalettin@calyptia.com> * ci: changed build method Signed-off-by: celalettin1286 <celalettin@calyptia.com> * ci: changed runner to windows 2019 Signed-off-by: celalettin1286 <celalettin@calyptia.com> * ci: add matrix for windows 2019 and 2022 Signed-off-by: celalettin1286 <celalettin@calyptia.com> * change job title Signed-off-by: celalettin1286 <celalettin@calyptia.com> --------- Signed-off-by: Celalettin Calis <celalettin@calyptia.com> Signed-off-by: celalettin1286 <celalettin@calyptia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7574 setting Chocolatey version to 1.4.0 since the version doesn't require .NET 4.8, also ensures the host version matches the container version.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.