Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Install config_format headers #7622

Merged
merged 1 commit into from Jul 3, 2023
Merged

Conversation

cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Jun 30, 2023

When using/installing Golang fluent-bit bindings, we need to install config_format related headers if someone wanted to use config_format related feature on that bindings.
Those headers are tightly coupled for the internal headers.
This lack of installation of cf headers causes inconvenient failures.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Hiroshi Hatake <hatake@calyptia.com>
Copy link
Collaborator

@niedbalski niedbalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edsiper edsiper merged commit ae48fda into master Jul 3, 2023
34 of 37 checks passed
@edsiper edsiper deleted the cosmo0920-install-cf_headers branch July 3, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants