Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emitter_create: exit and destroy instance on fail #7809

Conversation

BrewedCoffee
Copy link
Contributor

@BrewedCoffee BrewedCoffee commented Aug 8, 2023

Minor bugfix/cleanup

Noticing that the input instance is destroyed here on fail but not here, later in the code, I spoke with @leonardo-albertovich.

There is a global teardown for input instances, but regardless this cleanup should happen on exit as a best practice and in case that behavior changes. Also, "filters included in the processor stack unlink themselves from the global list" so would may not be cleaned up in the global shutdown.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [ N/A ] Example configuration file for the change
  • [ N/A ] Debug log output from testing the change
  • [ N/A ] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [ N/A ] Run local packaging test showing all targets (including any new ones) build.
  • [ N/A ] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [ N/A ] Documentation required for this feature

Backporting

  • [ N/A ] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@leonardo-albertovich
Copy link
Collaborator

leonardo-albertovich commented Aug 8, 2023

Top notch my friend, I've already approved the PR but you will need to fix the DCO issue in order for @edsiper to be able to merge it.

@BrewedCoffee BrewedCoffee temporarily deployed to pr August 8, 2023 18:25 — with GitHub Actions Inactive
@BrewedCoffee BrewedCoffee temporarily deployed to pr August 8, 2023 18:25 — with GitHub Actions Inactive
@BrewedCoffee BrewedCoffee temporarily deployed to pr August 8, 2023 18:25 — with GitHub Actions Inactive
Signed-off-by: Jeff <guywholikessoda@gmail.com>
@BrewedCoffee BrewedCoffee force-pushed the brewedcoffee-input-emitter-creation-cleanup branch from badfc65 to 35e11e7 Compare August 8, 2023 18:27
@BrewedCoffee BrewedCoffee temporarily deployed to pr August 8, 2023 18:43 — with GitHub Actions Inactive
@BrewedCoffee BrewedCoffee temporarily deployed to pr August 8, 2023 18:43 — with GitHub Actions Inactive
@BrewedCoffee BrewedCoffee temporarily deployed to pr August 8, 2023 18:43 — with GitHub Actions Inactive
@BrewedCoffee BrewedCoffee temporarily deployed to pr August 8, 2023 19:15 — with GitHub Actions Inactive
@nokute78 nokute78 merged commit 37772cc into fluent:master Aug 25, 2023
40 of 42 checks passed
@nokute78
Copy link
Collaborator

DCO issue was fixed and I merged.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants