in_calyptia_fleet: fix memory leaks during hot-reload of current and new configurations. #8133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a valgrind run: There are still some memory leaks which are out of scope for this PR:
I will attempt to address these in another pull request. |
Free memory during error handling when attempting to load new configurations. Remove code that initializes configurations during testing since it is impossible to free that memory later without crashing fluent-bit. This is due to the use of TLS variables for the co-routine parameters for outputs and how they are freed in flb_output_exit. Signed-off-by: Phillip Whelan <phil@calyptia.com>
Signed-off-by: Phillip Whelan <phil@calyptia.com>
Signed-off-by: Phillip Whelan <phil@calyptia.com>
…et_name. Signed-off-by: Phillip Whelan <phil@calyptia.com>
Signed-off-by: Phillip Whelan <phil@calyptia.com>
pwhelan
force-pushed
the
pwhelan-fleet-reload-leak
branch
from
611f94f
to
6d9d9be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have identified and fixed several memory leaks in fleet that happen during the reloading of the current configuration (when it exists from a previous run) or any new configurations loaded from the calyptia API.
test_config_is_valid.The function
test_config_is_validwas attempting to be far too intelligent by instantiating the configured plugins. Attempting to free the memory instantiated by the initialization is problematic sinceflb_output_exitalso frees the TLS variables it uses to store co-routine parameters, making it not thread-safe.Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.