Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: merge multiple Windows uploads together #8306

Merged
merged 1 commit into from Dec 19, 2023

Conversation

patrick-stephens
Copy link
Contributor

@patrick-stephens patrick-stephens commented Dec 19, 2023

Resolves failure in CI: https://github.com/fluent/fluent-bit/actions/runs/7260326110/job/19779963759

Previous to PR #8304 we were using v3 version of the action which allowed us to add all Windows binaries into the same package. Now we have separate packages so have to merge them together to properly sync to S3.

Taken from https://github.com/actions/download-artifact/tree/v4/?tab=readme-ov-file#download-multiple-filtered-artifacts-to-the-same-directory.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Patrick Stephens <pat@calyptia.com>
@patrick-stephens patrick-stephens merged commit 95bd000 into master Dec 19, 2023
18 checks passed
@patrick-stephens patrick-stephens deleted the 8298_upload_artifact_changes_fix_windows branch December 19, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant