multiline: respect emitter paused status #8511
Closed
+44
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braydonk
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
braydonk
force-pushed
the
multiline_drops
branch
from
65da7ef
to
1f250c5
Compare
braydonk
force-pushed
the
multiline_drops
branch
from
1f250c5
to
cb89edf
Compare
When the multiline plugin tries to send logs to the emitter, it never used to check if the emitter was paused or not. The input chunk appending routines would subsequently reject the log when it got to the point of checking if the current input plugin is paused. This would return -1 and cause the esoteric "error registering chunk for tag" message to be spammed constantly while the emitter is paused. This PR adds a check before appending logs to the emitter to see if it is currently paused. If it is, then the log will not be sent to the emitter and will be dropped (just as it would have been if it went through the rest of the chunk appending procedure, but cuts out all the extra steps). I have an automatic whitespace trimmer that runs on save, so there's lots of trailing whitespace deleted too sorry lol Signed-off-by: braydonk <braydonk@google.com>
braydonk
force-pushed
the
multiline_drops
branch
from
cb89edf
to
67c018b
Compare
|
On this PR I was able to easily test the scenario in |
|
Please see #8473 |
|
That's a much better solution, I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the multiline plugin tries to send logs to the emitter, it never used to check if the emitter was paused or not. The input chunk appending routines would subsequently reject the log when it got to the point of checking if the current input plugin is paused. This would return -1 and cause the esoteric "error registering chunk for tag" message to be spammed constantly while the emitter is paused.
This PR adds a check before appending logs to the emitter to see if it is currently paused. If it is, then the log will not be sent to the emitter and will be dropped (just as it would have been if it went through the rest of the chunk appending procedure, but cuts out all the extra steps).
I have an automatic whitespace trimmer that runs on save, so there's lots of trailing whitespace deleted too sorry lol
#4940
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.